Opened 8 months ago

Closed 7 months ago

#24584 closed defect (implemented)

Fix memory-leaked event_base_once() users.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: review-group-28
Cc: Actual Points:
Parent ID: #23847 Points:
Reviewer: dgoulet Sponsor:

Description

The event_base_once() function is prone to leak memory on event loop exit. This becomes a bigger problem once #23847 is in place.

Child Tickets

Change History (4)

comment:1 Changed 8 months ago by nickm

Status: assignedneeds_review

Fix in branch bug24584

comment:2 Changed 8 months ago by nickm

Keywords: review-group-28 added

comment:3 Changed 7 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready
  • For the beauty of well formed C files and to address any OCD issues some developers may have, I would add a new line after so it also matches the shutdown_did_not_work_event syntax. :)
/** Event to run initialize_periodic_events_cb */
static struct event *initialize_periodic_events_event = NULL;

rest lgtm;

comment:4 Changed 7 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Added blank line and merging!

Note: See TracTickets for help on using tickets.