#24595 closed defect (fixed)

hs_service_intro_circ_has_closed: Assertion desc failed

Reported by: asn Owned by:
Priority: High Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, assert, prop224
Cc: Actual Points:
Parent ID: Points: 0.2
Reviewer: asn Sponsor:

Description

Ugh. Our #23603 fix introduced a bug where we will fatal-assert the desc of an intro point in hs_service_intro_circ_has_closed() even tho we don't need it. Also that's a problem because we might have just removed the intro from the desc (e.g. because we failed it too much).

We need to fix this by not asserting on the desc.
We need to backport fix to 032 and master.

Dec 11 21:47:48.000 [info] cleanup_intro_points(): Intro point $C5BF27560E4B007365FBA96D32F9E74614218C8E (retried: 4 times). Removing it.
Dec 11 21:47:48.000 [err] tor_assertion_failed_(): Bug: src/or/hs_service.c:3134: hs_service_intro_circ_has_closed: Assertion desc failed; aborting. (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug: Assertion desc failed in hs_service_intro_circ_has_closed at src/or/hs_service.c:3134. Stack trace: (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(log_backtrace+0x42) [0x7f81a04a4582] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(tor_assertion_failed_+0x8c) [0x7f81a04bf5ac] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(hs_service_intro_circ_has_closed+0xdf) [0x7f81a04908cf] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(hs_circ_cleanup+0x7d) [0x7f81a047f5fd] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(circuit_mark_for_close_+0xd9) [0x7f81a03fdd39] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(hs_service_run_scheduled_events+0x4a9) [0x7f81a0492e89] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(+0x4c5b1) [0x7f81a036f5b1] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(+0x6c660) [0x7f81a038f660] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x7fc) [0x7f819f9a63dc] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(do_main_loop+0x254) [0x7f81a03736f4] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(tor_run_main+0x265) [0x7f81a0374a15] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(tor_main+0x3a) [0x7f81a036e2aa] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(main+0x19) [0x7f81a036e019] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1) [0x7f819eb992b1] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)
Dec 11 21:47:48.000 [err] Bug:     ./tor/src/or/tor(_start+0x2a) [0x7f81a036e06a] (on Tor 0.3.3.0-alpha-dev d5400d50e7ff0fe2)

Child Tickets

Change History (6)

comment:1 Changed 12 months ago by dgoulet

Priority: MediumHigh
Summary: hs_service_intro_circ_has_closed: Assertion desc failedhs_service_intro_circ_has_closed: Assertion desc failedhs_service_intro_circ_has_closed: Assertion desc failed

comment:2 Changed 12 months ago by asn

Keywords: prop224 added
Reviewer: asn

comment:3 Changed 12 months ago by dgoulet

Status: newneeds_review

Branch: bug24595_032_01

Fortunately for us, this bug was never released so no changes file. Introduced in e80893e51b0c0320838cbed8c46fd5b0fe608bef

comment:4 Changed 12 months ago by dgoulet

asn changed it and I approve so here is the second version: bug24595_032_02

comment:5 Changed 12 months ago by asn

Status: needs_reviewmerge_ready

bug24595_032_02 LGTM!

comment:6 Changed 12 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merging to 0.3.2 and master.

Note: See TracTickets for help on using tickets.