Opened 6 months ago

Closed 5 months ago

#24600 closed enhancement (fixed)

Add fallback nicknames to the file, so stem can use them

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Fallback Scripts Version:
Severity: Normal Keywords: fallback, stem, review-group-28
Cc: teor@… Actual Points: 0.2
Parent ID: #22271 Points: 0.5
Reviewer: pastly Sponsor:

Description

We should do this in a machine-readable comment, to avoid inflating the tor binary with useless data.

Child Tickets

Change History (12)

comment:1 Changed 6 months ago by teor

Owner: set to teor
Status: newassigned

comment:2 Changed 6 months ago by teor

Actual Points: 0.2
Keywords: fallback stem added
Status: assignedneeds_review

Please see my branch ticket24600_tree, which is based on ticket24679.
(Otherwise, there would be a lot of merge conflicts.)

I'd like to get feedback from atagar and irl on the new fallback format before we merge this.

comment:3 Changed 6 months ago by atagar

Hi Tim. Tomorrow I plan to add stem support for the new format. If I run into any hiccups I'll let ya know.

comment:4 Changed 6 months ago by teor

I have merged all fallback format 2.0.0 changes into my branch fallback-format-2.

comment:5 Changed 6 months ago by teor

Now this branch is fallback-format-2-v2.
There are no changes to the commits for this ticket.

comment:6 Changed 6 months ago by teor

I squashed the original branch into fallback-format-2-v3 on https://github.com/teor2345/tor.git

comment:7 Changed 6 months ago by nickm

Keywords: review-group-28 added

comment:8 Changed 6 months ago by teor

Please see my revised branch fallback-format-2-v4 at https://github.com/teor2345/tor.git

pastly found some whitelist and blacklist changes from #22321 that I'd accidentally included in some commits, so I took them out.

comment:9 Changed 6 months ago by pastly

Status: needs_reviewmerge_ready

Nicknames are added. LGTM, but make sure all fallback-format-2-v4 tickets are merge_ready.

comment:10 Changed 6 months ago by teor

This code is now in my branch fallback-code-2018-01 at https://github.com/teor2345/tor.git

comment:11 Changed 6 months ago by teor

Reviewer: pastly

pastly reviewed all of these

comment:12 Changed 5 months ago by teor

Resolution: fixed
Status: merge_readyclosed

This branch has been merged, so these tickets are now implemented,

Note: See TracTickets for help on using tickets.