Opened 18 months ago

Last modified 14 months ago

#24604 new defect

Decorate IPv6 addresses in connection_t->address to avoid ambiguity

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6, tor-relay, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: #24403 Points: 2
Reviewer: Sponsor: SponsorV-can

Description

Currently, connection_t->address can be in one of three formats:

  • hostname: www.example.com
  • IPv4: 1.1.1.1
  • IPv6: 2003::0001

Tor often uses this address with a port like this:

  • hostname: www.example.com:1234
  • IPv4: 1.1.1.1:1234
  • IPv6: 2003::0001:1234

The IPv6 case is ambiguous, and we should fix it.

One way of fixing it is to provide a flag if address is an IPv6 literal, and a function to format address and port. (Unfortunately, we can't always decorate IPv6 addresses, because that would cause bugs in other code and in controllers.)

Then we would need to go through every instance of conn->address and find the ones that use a port. This may also require a spec update, like #24603.

Child Tickets

Change History (4)

comment:1 Changed 16 months ago by teor

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

The 0.3.3 freeze deadline has passed, all these children of #24403 belong in 0.3.4

comment:2 Changed 14 months ago by nickm

Keywords: 034-triage-20180328 added

comment:3 Changed 14 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:4 Changed 14 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.