Opened 2 months ago

Closed 2 months ago

#24612 closed defect (implemented)

Fix pretty printing of configure output for rust checks

Reported by: isis Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version: Tor: 0.3.1.3-alpha
Severity: Normal Keywords: tor-build, autoconf
Cc: Actual Points:
Parent ID: Points: .1
Reviewer: Sponsor:

Description

Right now we print:

[…]
checking for cargo... cargo
checking rust crate dependencies... checking rust version... checking for library containing socket... none required
[…]

I think we're supposed to use AC_MSG_RESULT to print "yes" if the rust crate dependency checks go okay. After the "checking rust version" we should probably also print something indicating that the version was acceptible (I'd personally go for printing the version string, since it doesn't hurt to have that in the build logs).

Child Tickets

Change History (5)

comment:1 Changed 2 months ago by isis

Status: newneeds_review

Fix in my bug24612 branch.

comment:2 Changed 2 months ago by isis

Version: Tor: 0.3.2.1-alphaTor: 0.3.1.3-alpha

comment:3 Changed 2 months ago by nickm

Status: needs_reviewmerge_ready

We can take this in master, but the patch doesn't apply to 0.3.2. I'm inclined to say that master is good enough here, if you agree.

comment:4 Changed 2 months ago by isis

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

Sure, that sounds fine, it's just cosmetic.

comment:5 Changed 2 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.