#24621 closed defect (fixed)

Exclude lastModifiedMillis in index.json

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/CollecTor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I noticed that we're including a lastModifiedMillis field in the index.json produced by CollecTor. Here's a local example:

{
  "index_created": "2017-12-14 08:43",
  "build_revision": "56a303e",
  "path": "https://collector.torproject.org",
  "directories": [
    {
      "path": "recent",
      "directories": [
        {
          "path": "bridge-descriptors",
          "directories": [
            {
              "path": "extra-infos",
              "files": [
                {
                  "path": "2017-10-25-18-30-02-extra-infos",
                  "size": 12059081,
                  "last_modified": "2017-10-25 18:30",
                  "lastModifiedMillis": 0     <--------------------
                }
              ]
            },

The reason is that we're using our own Gson instance in CollecTor, and we need to specifically say that we want it to exclude fields without the @Expose annotation. Let's do that. Trivial patch follows.

Child Tickets

Change History (3)

comment:1 Changed 18 months ago by karsten

Status: newneeds_review

comment:2 Changed 18 months ago by iwakeh

Status: needs_reviewmerge_ready

Good catch!
Ready for merge.

comment:3 Changed 18 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Great! Merged to master. Closing.

Note: See TracTickets for help on using tickets.