Opened 10 months ago

Closed 4 months ago

#24630 closed defect (fixed)

Stop initialising rust git submodules, travis does this automatically

Reported by: teor Owned by:
Priority: Very Low Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: tor-ci, teor-was-assigned, 034-triage-20180328, 034-removed-20180328 very-small
Cc: alex_y_xu@… Actual Points:
Parent ID: Points: 0.1
Reviewer: isis Sponsor:

Description

isis told me to do this.

Child Tickets

Change History (15)

comment:1 Changed 10 months ago by teor

Status: assignedneeds_revision

Ok, I've run out of time for this, there are commits for this issue and #24629 in my branch travis-osx-v2. Feel free to keep hacking on it!

comment:2 Changed 9 months ago by ahf

Keywords: 032-backport added
Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

Moving this to 0.3.3 - it might make sense to backport this fix for the maint-0.3.2 branch?

comment:3 Changed 9 months ago by teor

Keywords: teor-was-assigned added
Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final
Owner: teor deleted
Status: needs_revisionassigned

Unassigning myself from less important tickets, and moving them to 0.3.4

comment:4 Changed 7 months ago by nickm

Keywords: 034-triage-20180328 added

comment:5 Changed 7 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:6 Changed 6 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:7 Changed 6 months ago by Hello71

Cc: alex_y_xu@… added
Priority: MediumVery Low
Severity: NormalMinor
Status: assignedneeds_review

unless I'm missing something, we can just cherry-pick https://github.com/teor2345/tor/commit/d219c568abb82e4c564fb8fe95eeb4ac423affc2 onto the relevant branches. it's not strictly necessary, but good to remove unnecessary cruft.

comment:8 Changed 6 months ago by nickm

Keywords: very-small added
Milestone: Tor: unspecifiedTor: 0.3.4.x-final

comment:9 Changed 6 months ago by dgoulet

Reviewer: isis

comment:10 Changed 6 months ago by isis

Status: needs_reviewmerge_ready

LGTM; if teor agrees, I think we should do Hello71's suggestion to cherry-pick d219c568abb82e4c564fb8fe95eeb4ac423affc2 onto 0.3.2 and 0.3.3.

comment:11 Changed 6 months ago by teor

Let's do it

comment:12 Changed 6 months ago by nickm

I cherry-picked that commit to 0.3.3 as b116710e313c6debf9bc172e462837782def57bd . It didn't seem to apply to 0.3.2, however. Am I missing something?

comment:13 Changed 6 months ago by Hello71

conflicts with 57e2f21bd8966e1ce4f9da5e9f6e7dcbe1fe0c6c by isis, doesn't have a bug number but apparently that wasn't backported to 0.3.2.

options:

  1. don't bother cherry-picking this to 0.3.2. good if we don't intend to use travis on maint branches. I think that's a good idea though, so probably not a good decision.
  1. cherry-pick 57e2f21bd8966e1ce4f9da5e9f6e7dcbe1fe0c6c too
  1. "merge" by leaving out offline Rust builds entirely

option 2 sounds good if isis is on board.

comment:14 Changed 6 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: 0.3.2.x-final
Status: merge_readyneeds_revision

comment:15 Changed 4 months ago by teor

Keywords: 032-backport removed
Resolution: fixed
Status: needs_revisionclosed

There's no need to backport an efficiency patch

Note: See TracTickets for help on using tickets.