Update macOS toolchain for ESR 60

This bug will cover the macOS related changes for the ESR 59 switch.

added GeorgKoppen201805 TorBrowserTeam201806R component::applications/tor browser ff60-esr owner::tbb-team parent::24631 priority::very high resolution::fixed severity::normal status::closed tbb-rbm type::defect labels

We need at least a newer SDK (https://bugzilla.mozilla.org/show_bug.cgi?id=1324892). It seems building with the older one is causing more and more crashes on newer Apple hardware. :(

Trac:
Keywords: N/A deleted, ff59-esr added

We need a newer cctools and clang, too, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1337233 (might be another good opportunity to finally solve #9711 (moved)?)

Firefox 60 is the new ESR.

Trac:
Keywords: ff59-esr deleted, ff60-esr added

Trac:
Summary: Update macOS toolchain for ESR 59 to Update macOS toolchain for ESR 60

Trac:
Keywords: N/A deleted, TorBrowserTeam201804 added

Trac:
Priority: Medium to High

Trac:
Keywords: N/A deleted, tbb-rbm added

Move our roadmap tickets to May.

Trac:
Keywords: TorBrowserTeam201804 deleted, TorBrowserTeam201805 added

Trac:
Keywords: N/A deleted, GeorgKoppen201805 added

Trac:
Priority: High to Very High

I opened to #26251 (moved) to track the snowflake related changes. We wont' wait for them though before switching our macOS nightly builds to ESR 60. Thus, I'll disable snowflake for the time being in case it takes a bit longer to adapt it to the new toolchain.

The first pre-nightly Tor Browser based on ESR 60 finished building. Could someone with recent enough macOS systems test whether the bundle is at least running?

https://people.torproject.org/~gk/testbuilds/TorBrowser-tbb-nightly-esr60-osx64_en-US.dmg https://people.torproject.org/~gk/testbuilds/TorBrowser-tbb-nightly-esr60-osx64_en-US.dmg.asc

Trac:
Cc: N/A to mcs, brade

Trac:

Replying to gk:

The first pre-nightly Tor Browser based on ESR 60 finished building. Could someone with recent enough macOS systems test whether the bundle is at least running?

I did some quick tests on a Retina MacBook Pro (macOS 10.13.4) and on an older iMac (macOS 10.11.6). Good news so far: the only problem I noticed that might not be known yet is that the app icon was positioned incorrectly within the DMG installer window: I am not sure what caused that problem, but we should fix it when we re-do that window to use the new icon.

Replying to mcs:

Good news so far: the only problem I noticed that might not be known yet is that the app icon was positioned incorrectly within the DMG installer window....

I created #26263 (moved) to track this issue.

Replying to mcs:

Replying to gk:

The first pre-nightly Tor Browser based on ESR 60 finished building. Could someone with recent enough macOS systems test whether the bundle is at least running?

I did some quick tests on a Retina MacBook Pro (macOS 10.13.4) and on an older iMac (macOS 10.11.6). Good news so far: the only problem I noticed that might not be known yet is that the app icon was positioned incorrectly within the DMG installer window:

That's great news, thanks! I posted patches for all child bugs. I'll add patches for the remaining bugs on a branch for this ticket including all the other patches, too, in order to have one branch which one can actually use to test building the whole thing.

bug_24632_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_24632_v2) has all the 8 patches to fix this bug. Please review.

Trac:
Status: new to needs_review
Cc: mcs, brade to mcs, brade, boklm
Keywords: TorBrowserTeam201805 deleted, TorBrowserTeam201806R added

I cherry-picked the following commits on master:

• 7997d2322347f742e7f4ede47379119faeb03bdd: Bug 24632: Use our new toolchain for rustc compilation
• 3b5038d90cac5cfcf6856cc0786cfa99adbc775a: Bug 24632: Adapt tor and OpenSSL for new macOS toolchain
• a0130c9a178ae919a400ad014d7f855a282c72b4: Bug 24632: Bump clang version in go build script comment
• 3db16b9c473ec950452126700fc1e22f71ed8190: Bug 24632: Disable snowflake for macOS for now

The last missing one is Bug 24632: Adapt firefox and tor-browser to new macOS toolchain. For this one, I think we don't need to include llvm in the firefox build for macOS, as it is already included in macosx-toolchain. So I suggest the following change (fixup commit to be squased after review): https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_26003_v2&id=6f7ae06bbae28efc8a84db504c1ceb1744bb8a88

That's a good point, thanks. I squashed your commit into mine and pushed everything to master (commit e76952c389487d657c3f52fede5e9ca56ec02397). So, we are supposed to be good. \o/

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

We needed two small fixups here:

commit aabed936170b9ea88df2037e8d452dc5d9915f20 which installs xz-utils which we now need for MAR file generation and commit fcb2a3707af71bcd564bf0dd8a563835eeea6b9b which fixed a missing "TorBrowser.app" -> "Tor Browser.app" transition.

closed

mentioned in issue #26261 (moved)

mentioned in issue #26319 (moved)

moved to tpo/applications/tor-browser#24632 (closed)

mentioned in issue tpo/applications/tor-browser#26319 (closed)