#24634 closed defect (fixed)

test_hs_common.c:974:33: warning: declaration of 'time' shadows a global declaration

Reported by: asn Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, jenkins
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

09:54:31 [0m[0m../src/test/test_hs_common.c: In function 'set_consensus_times':
09:54:43 [0m[0m../src/test/test_hs_common.c:974:33: warning: declaration of 'time' shadows a global declaration [-Wshadow]
[ https://jenkins.torproject.org/job/tor-debian-release-binaries-arm/18/ARCHITECTURE=armhf,SUITE=wheezy/consoleFull ]

Child Tickets

Attachments (1)

consoleText (836.0 KB) - added by weasel 21 months ago.

Download all attachments as: .zip

Change History (7)

Changed 21 months ago by weasel

Attachment: consoleText added

comment:1 Changed 21 months ago by asn

Also:

09:40:36 mm../src/or/hs_common.c:987:21: warning: declaration of 'dup' shadows a global declaration [-Wshadow]

comment:2 Changed 21 months ago by weasel

weasel@orinoco:~$ grep -i shadows consoleText | sort -u
../src/or/hs_common.c:987:21: warning: declaration of 'dup' shadows a global declaration [-Wshadow]
../src/or/hs_service.c:1193:31: warning: declaration of 'dup' shadows a global declaration [-Wshadow]
../src/or/hs_service.c:2279:20: warning: declaration of 'index' shadows a global declaration [-Wshadow]
../src/test/test_hs_common.c:974:33: warning: declaration of 'time' shadows a global declaration [-Wshadow]

comment:3 Changed 21 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:4 Changed 21 months ago by nickm

Status: acceptedneeds_review

bug24634 has the logical set of fixes here. It should merge cleanly into maint-0.3.2

comment:5 Changed 21 months ago by asn

Status: needs_reviewmerge_ready

LGTM! :)

comment:6 Changed 21 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.