Opened 3 years ago

Closed 3 years ago

#24636 closed defect (fixed)

moat-transports response not sent

Reported by: mcs Owned by: isis
Priority: Very High Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Normal Keywords: bridgedb-moat
Cc: brade Actual Points:
Parent ID: #24689 Points: 1
Reviewer: Sponsor: SponsorV


When sending a /fetch request and there is no overlap with the transports which BridgeDB supports, the moat responder does not generate a moat-transports response. Instead, a moat-challenge response is sent that includes an array of transports.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by isis

I totally specified this differently than the behaviour, sorry.

Now I'm wondering if I should just change the spec to match the actual behaviour? Would that be okay with you? My reasoning is that, if there were no commonly-supported transports, sending the list of transports that BridgeDB does support back at the same time as a new CAPTCHA potentially saves a roundtrip (should the user/agent decide they can actually support one of the available transports).

comment:2 Changed 3 years ago by isis

Keywords: bridgedb-moat added
Status: newneeds_information

comment:3 Changed 3 years ago by mcs

Status: needs_informationnew

Kathy and I are okay with just changing the spec. It seems better (as you said, it could save a roundtrip) and simpler (one fewer message type to generate and parse). So the spec would be:

  • send back a single string for the transport if there is overlap btw client and server
  • send back an array of the supported transports if there is no overlap

If that sounds correct you should re-purpose this ticket to track the required spec change.

comment:4 Changed 3 years ago by mcs

Parent ID: #24689

comment:5 Changed 3 years ago by isis

Points: 1
Priority: MediumVery High
Resolution: fixed
Sponsor: SponsorV
Status: newclosed

Fixed in my fix/24636 branch.

Note: See TracTickets for help on using tickets.