Opened 7 months ago

Closed 6 months ago

#24641 closed defect (implemented)

Simplify "did this option change" functions in config.c

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: review-group-28
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There's a great deal of boilerplate here, in all the options_transition_* functions. I hate to say it, but this seems like a job for macros.

Child Tickets

Change History (4)

comment:1 Changed 7 months ago by nickm

Status: assignedneeds_review

See simplify_transition_allowed in my public repository.

comment:2 Changed 7 months ago by nickm

Keywords: review-group-28 added

comment:3 Changed 6 months ago by ahf

Status: needs_reviewmerge_ready

LGTM.

comment:4 Changed 6 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

merging!

Note: See TracTickets for help on using tickets.