Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2465 closed defect (fixed)

Fix Javascript hooks on Firefox 4

Reported by: mikeperry Owned by: mikeperry
Priority: Very High Milestone:
Component: Applications/Torbutton Version:
Severity: Keywords: MikePerryIterationFires20110305 TorbuttonIterationFires20110305
Cc: Actual Points: 2
Parent ID: Points: 2
Reviewer: Sponsor:

Description

Wheee. Our dream scenario: something about the Fifefox javascript interpretor changed, and our Javascript hooks no longer seem to be working right. Instead of overriding the relevant window properties with lies, we appear to be somehow disabling them, making their values unavailable, and probably actively breaking some sites as a result.

Yet one more reason to fork Firefox.

Anyways, we might be able to fix this, with some luck, in extension-land. This bug seeks to chronicle that adventure.

Child Tickets

TicketStatusOwnerSummaryComponent
#2421closedmikeperryTorbutton Exception in sandbox evaluation., Date hooks not applied: TypeError: (void 0) is undefinedApplications/Torbutton

Change History (6)

comment:1 Changed 9 years ago by mikeperry

Component: - Select a componentTorbutton
Owner: set to mikeperry
Priority: normalcritical

comment:2 Changed 9 years ago by mikeperry

Points: 10

Test alternate methods: 7
Cleanup: 3

comment:3 Changed 9 years ago by mikeperry

Note to self: try to solve this one in conjunction with the window.name issue (bug #1968).

comment:4 Changed 9 years ago by mikeperry

Actual Points: 2
Keywords: MikePerryIterationFire20110305 added
Resolution: fixed
Status: newclosed

Woo-hoo. While fixing an javascript hooks exception on 4.0b11, I accidentally 'fixed' this bug. Our javascript hooks are functional again, at least. They could use a bit more work, but that is for another day and another ticket.

Fix is in git.

comment:5 Changed 9 years ago by mikeperry

Keywords: MikePerryIterationFires20110305 TorbuttonIterationFires20110305 added; MikePerryIterationFire20110305 removed

comment:6 Changed 9 years ago by mikeperry

Points: 102
Note: See TracTickets for help on using tickets.