Opened 5 months ago

Closed 5 months ago

#24677 closed defect (fixed)

Use ping ::1 on Linux when ping6 ::1 fails

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version: Tor: 0.2.9.3-alpha
Severity: Normal Keywords: easy intro test ipv6
Cc: ffmancera Actual Points:
Parent ID: Points: 0.2
Reviewer: teor Sponsor:

Description

Turns out that some Linuxes don't have ping6, but ping ::1 works just fine.

This is a one-line change in Makefile.am

Child Tickets

Change History (9)

comment:1 Changed 5 months ago by ffmancera

Status: newneeds_review

Done! Check my github branch bug24677.

PD: I have also added failure and success message :)

comment:2 Changed 5 months ago by nickm

Reviewer: teor

looks plausible to me; do you like it, teor?

comment:3 Changed 5 months ago by teor

Status: needs_reviewmerge_ready

Seems fine to me, I updated the comments to match the new code in my branch bug24677.
(Aren't standards great?)

This passes make test-network-all on macOS (BSD) and Ubuntu (ping6 Linux), so the patch preserves existing behaviour.

comment:4 Changed 5 months ago by teor

Status: merge_readyneeds_revision

The changes file syntax for bugs is slightly different, it references the tor version that the bug was introduced in. Please update the changes file, and flip the ticket back to merge_ready.

comment:5 Changed 5 months ago by teor

Oh, don't forget my extra commit with the comment changes. My branches are at https://github.com/teor2345/tor.git

Also, feel free to credit yourself in the changes file using "Patch by (preferred name or handle)".

comment:6 Changed 5 months ago by ffmancera

Status: needs_revisionmerge_ready

I wanted to add your commit on my branch but I wasn't able to. So I make the comment changes on my commit if you can give me a patch file of the commit I will add it :-).

All changes are in my github branch bug24677

comment:7 in reply to:  6 Changed 5 months ago by teor

Replying to ffmancera:

I wanted to add your commit on my branch but I wasn't able to.

It's ok, I don't mind.

But next time, try:

git remote add teor https://github.com/teor2345/tor.git
git fetch teor
git cherry-pick teor/bug24677

Also, in future, adding extra commits for each review helps us review faster, because it's easier to see what has changed.

So I make the comment changes on my commit if you can give me a patch file of the commit I will add it :-).

All changes are in my github branch bug24677

Thanks for the update!

I'm not sure if nickm will mind that you used "Minor features" on a bugfix ticket.
I'll leave that up to him.

comment:8 Changed 5 months ago by ffmancera

Okay, I will follow your advice for the next time, thanks!

Also, I changed the "Minor features" to "Minor bugfix".

Last edited 5 months ago by ffmancera (previous) (diff)

comment:9 Changed 5 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

looks okay to me, and seems to work: merged to master!

Note: See TracTickets for help on using tickets.