Opened 2 months ago

Last modified 2 weeks ago

#24688 assigned defect

timing wheels should use 32-bit math on 32-bit platforms

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: cpu, 32-bit, timing
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor8-can

Description

I think this might help our 32-bit performance a bit.

Not putting this in needs_review yet, since it needs more analysis.

diff --git a/src/common/timers.c b/src/common/timers.c
index 93cde7de5fbd4b..3c806b7f4b422a 100644
--- a/src/common/timers.c
+++ b/src/common/timers.c
@@ -66,6 +66,11 @@ struct timeout_cb {
  * above TIMEOUT_MAX can also be super-inefficent. Choosing 5 here sets
  * timeout_max to 2^30 ticks, or 29 hours with our value for USEC_PER_TICK */
 #define WHEEL_NUM 5
+#if SIZEOF_VOID_P == 4
+/* On 32-bit platforms, we want to override wheel_bit, so that timeout.c will
+ * use 32-bit math. */
+#define WHEEL_BIT 5
+#endif
 #include "src/ext/timeouts/timeout.c"
 
 static struct timeouts *global_timeouts = NULL;

Child Tickets

Change History (1)

comment:1 Changed 2 weeks ago by nickm

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Mark a lot of assigned/needs_revision tickets as 0.3.4. If you think this should happen in 0.3.3 instead, just let me know?

Note: See TracTickets for help on using tickets.