Opened 2 years ago

Closed 21 months ago

#24713 closed defect (fixed)

Make pgTAP test work again

Reported by: iwakeh Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Statistics Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: iwakeh Sponsor:

Description (last modified by iwakeh)

The userstats tests. Some tweaks were already supplied (cf. the other commits on the mentioned branch), but the tests fail still.

Currently the tests fail b/c of the commented SELECT merge(); calls. But these would prevent the tests from running at all b/c of ERROR: relation "merged_part" already exists. There are approx. 25 calls to merge().

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by iwakeh

Description: modified (diff)

comment:2 Changed 22 months ago by karsten

Cc: metrics-team added
Owner: changed from metrics-team to karsten
Status: newaccepted

I worked on this and am going to post a branch here in a second.

comment:3 Changed 22 months ago by karsten

Status: acceptedneeds_review

Please review commit f6257c1 in my task-24713 branch. The commit message contains all the details why this commit fixes the bug.

comment:4 Changed 21 months ago by karsten

Reviewer: iwakeh

Optimistically assigning to iwakeh's review queue. Feel free to give it back if you don't want it.

comment:5 Changed 21 months ago by iwakeh

Status: needs_reviewmerge_ready

This is fine now, runs, and passes.

comment:6 Changed 21 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Great, thanks for checking! Closing.

Note: See TracTickets for help on using tickets.