Opened 6 months ago

Closed 5 months ago

#24725 closed enhancement (fixed)

Add a format version number to the fallback file

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Fallback Scripts Version:
Severity: Normal Keywords: fallback, review-group-28
Cc: teor@… Actual Points:
Parent ID: #22271 Points: 0.2
Reviewer: pastly Sponsor:

Description

atagar asked for this, and it's a good idea.

Let's use semantic versioning:

  • major versions are for incompatible changes, like removing non-optional fields
  • minor versions are for compatible changes, like adding fields
  • patch versions are for bug fixes, like changing an incorrectly-formatted header comment

Child Tickets

Change History (9)

comment:1 Changed 6 months ago by teor

I have merged all fallback format 2.0.0 changes into my branch fallback-format-2.

comment:2 Changed 6 months ago by teor

See fallback-format-2-v2, which also adds a delimiter at the end of every entry.

comment:3 Changed 6 months ago by teor

I squashed the original branch into fallback-format-2-v3 on https://github.com/teor2345/tor.git

comment:4 Changed 6 months ago by teor

Keywords: review-group-28 added
Status: assignedneeds_review

Oops, this was meant to be in needs review with the other tickets on this branch.
Sticking it in review-group-28, because they'll be reviewed together.

comment:5 Changed 6 months ago by teor

Please see my revised branch fallback-format-2-v4 at https://github.com/teor2345/tor.git

pastly found some whitelist and blacklist changes from #22321 that I'd accidentally included in some commits, so I took them out.

comment:6 Changed 6 months ago by pastly

Status: needs_reviewmerge_ready

Version number is added. LGTM, but make sure all fallback-format-2-v4 tickets are merge_ready.

comment:7 Changed 6 months ago by teor

This code is now in my branch fallback-code-2018-01 at https://github.com/teor2345/tor.git

comment:8 Changed 6 months ago by teor

Reviewer: pastly

pastly reviewed all of these

comment:9 Changed 5 months ago by teor

Resolution: fixed
Status: merge_readyclosed

This branch has been merged, so these tickets are now implemented,

Note: See TracTickets for help on using tickets.