#24726 closed enhancement (fixed)
Make sure a comma never appears anywhere in a fallback entry
| Reported by: | teor | Owned by: | teor |
|---|---|---|---|
| Priority: | Medium | Milestone: | Tor: 0.3.3.x-final |
| Component: | Core Tor/Fallback Scripts | Version: | |
| Severity: | Normal | Keywords: | fallback, review-group-28 |
| Cc: | Actual Points: | 0.1 | |
| Parent ID: | #22271 | Points: | 0.1 |
| Reviewer: | pastly | Sponsor: |
Description
This possibly requires an update to our strong cleansing routines, or just adding a comment to them.
Child Tickets
Change History (11)
comment:1 Changed 2 years ago by
| Actual Points: | → 0.1 |
|---|---|
| Status: | assigned → needs_review |
| Type: | defect → enhancement |
comment:2 Changed 2 years ago by
I have merged all fallback format 2.0.0 changes into my branch fallback-format-2.
comment:4 Changed 2 years ago by
I squashed the original branch into fallback-format-2-v3 on https://github.com/teor2345/tor.git
comment:5 Changed 2 years ago by
| Keywords: | review-group-28 added |
|---|
comment:6 Changed 2 years ago by
Please see my revised branch fallback-format-2-v4 at https://github.com/teor2345/tor.git
pastly found some whitelist and blacklist changes from #22321 that I'd accidentally included in some commits, so I took them out.
comment:7 Changed 2 years ago by
| Status: | needs_review → merge_ready |
|---|
Commas are in fact removed Tested by adding as,df to all nicknames and verifying output nicknames only had asdf added. Also visually checked code that all %s formatters in the fallback entry code had a call to cleanse_c_string.
LGTM, but make sure all fallback-format-2-v4 are merge_ready.
comment:8 Changed 2 years ago by
This code is now in my branch fallback-code-2018-01 at https://github.com/teor2345/tor.git
comment:10 Changed 2 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | merge_ready → closed |
This branch has been merged, so these tickets are now implemented,
This could confuse parsers, so we don't allow it.
Please see my branch ticket24726.