Opened 7 months ago

Closed 7 months ago

#24743 closed defect (fixed)

Stem's MAX_MICRODESCRIPTOR_HASHES is slightly too high

Reported by: teor Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When used with an IPv6 address, it should be 90. (Tor just uses 90 all the time, I'm not sure if 92 was ever accurate.)

See Tor's max_dl_per_request() for the calculations, this was changed in tor-0.2.8.1-alpha.

Child Tickets

Change History (1)

comment:1 Changed 7 months ago by atagar

Resolution: fixed
Status: newclosed

Hi Tim, took a peek through the history and seems the 92 limitation is due to the url length for squid proxies. Here's the commit where it was added...

https://gitweb.torproject.org/stem.git/commit/?id=749c8d37

Turns out that Tor had a limit of 92 too but dropped it to 90 in 2016...

https://gitweb.torproject.org/tor.git/commit/?id=91077d3a

Change pushed...

https://gitweb.torproject.org/stem.git/commit/?id=7a54d54

Thanks for pointing this out!

Note: See TracTickets for help on using tickets.