Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#2475 closed defect (fixed)

Split SIZE_T_CEILING, SSIZE_T_CEILING

Reported by: nickm Owned by:
Priority: High Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords: easy tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For good C practice, we should have separate signed and unsigned values for the ssize_t and size_t ceilings, and avoid signed-to-unsigned comparisons. See comments in bug #2337 for background.

(We don't want to just make SIZE_T_CEILING unsigned and use it everwhere, since comparing a ssize_t to an unsigned SIZE_T_CEILING is just as broken as comparing a size_t to a signed SIZE_T_CEILING.)

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

See branch bug2475 against maint-0.2.1 in my public repo. I found no actual brokenness here, but it's best to avoid signed/unsigned comparison anyways.

comment:2 Changed 8 years ago by arma

Looks fine to me. (We should try to test builds on various places before we tag a new 0.2.1, so we don't release something that's broken somewhere. I guess including this change in the next 0.2.2 release will be enough.)

comment:3 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merging.

comment:4 Changed 7 years ago by nickm

Keywords: tor-client added

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:6 Changed 6 years ago by nickm

Milestone: Tor: 0.2.1.x-final

Milestone Tor: 0.2.1.x-final deleted

Note: See TracTickets for help on using tickets.