Opened 2 years ago

Last modified 3 days ago

#24844 needs_review enhancement

Add HS v3 status to the SIGUSR1 dumpstats()

Reported by: dgoulet Owned by: neel
Priority: Low Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, 034-triage-20180328, 034-removed-20180328
Cc: neel Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:

Description

Only v2 is supported with rend_service_dump_stats(). Would be nice to have one for v3 as well.

Child Tickets

Change History (15)

comment:1 Changed 2 years ago by nickm

Keywords: 034-triage-20180328 added

comment:2 Changed 2 years ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:3 Changed 2 years ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:4 Changed 8 days ago by neel

Cc: neel added
Owner: set to neel
Status: newassigned

comment:5 Changed 8 days ago by neel

Status: assignedneeds_review

comment:6 Changed 8 days ago by teor

Milestone: Tor: unspecifiedTor: 0.4.4.x-final

comment:7 Changed 6 days ago by asn

Reviewer: asn

comment:8 Changed 6 days ago by asn

Status: needs_reviewneeds_revision

Looks nice! Almost there. Did some reviews on the PR! Thanks!

comment:9 Changed 6 days ago by neel

Status: needs_revisionneeds_review

Thanks for the suggestion. I pushed my changes.

comment:10 Changed 6 days ago by neel

Status: needs_reviewneeds_revision

comment:11 Changed 6 days ago by neel

Status: needs_revisionneeds_review

comment:12 Changed 4 days ago by asn

Status: needs_reviewneeds_revision

Another review done! Thanks for the fixes!

comment:13 Changed 4 days ago by neel

Status: needs_revisionneeds_review

comment:14 in reply to:  13 Changed 3 days ago by asn

Status: needs_reviewneeds_revision

One more revision. Really close now!

comment:15 Changed 3 days ago by neel

Status: needs_revisionneeds_review

Added a log message, setting as needs review.

Note: See TracTickets for help on using tickets.