Opened 13 days ago

Last modified 6 days ago

#24854 new enhancement

Extract the authority list from config.c

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: torspec, tor-dirauth, 029-backport, 030-backport, 031-backport, 032-backport
Cc: beastr0@… Actual Points:
Parent ID: #24818 Points: 0.2
Reviewer: Sponsor:

Description (last modified by teor)

There is a list of default_authorities in src/or/config.c.
We want it in a separate file at src/or/auth_dirs.inc.

This should be implemented like the default_fallbacks array, which includes the fallback list from src/or/fallback_dirs.inc.

We will need to implement two branches for backporting:

  • a branch on maint-0.2.9 for 0.2.9 and later. It has IPv6 addresses.
  • a branch on maint-0.2.5 for 0.2.5. It has no IPv6 addresses.

(Then, after we have moved it into a separate file, we want to automatically generate the file, in a new format. See the rest of the children of #24818.)

Child Tickets

Change History (10)

comment:1 Changed 13 days ago by beastr0

Cc: beastr0@… added

comment:2 Changed 12 days ago by beastr0

Should this function/method (can't remember which one it's called in C) be written in the config.c file or somewhere else?

comment:3 Changed 12 days ago by teor

I don't think we need to modify any functions for this patch.

This patch should #include "auth_dirs.inc" in config.c at compile time, like we do a few lines later in config.c with "fallback_dirs.inc".

(Sorry, that wasn't very obvious.)

comment:4 Changed 11 days ago by beastr0

I've been crawling through the files, just getting myself oriented, and I think I see where I went wrong. Ha, wow, nice and easy fix. Should I also create the auth_dirs.inc file or is that #24853?

comment:5 Changed 11 days ago by teor

Please create the file by copying and pasting the current contents of the array.
Then we can modify the format of the file in #24851, and backport it in #24853.

comment:6 Changed 7 days ago by teor

Keywords: 025-backport removed

We won't backport this to 0.2.5, because the format is missing ipv6. Instead, we will manually backport any authority changes that happen before May 2018 when 0.2.5 is EOL.

comment:7 Changed 7 days ago by teor

Description: modified (diff)

comment:8 Changed 7 days ago by teor

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

We have time to do these, let's do them well in 0.3.4

comment:9 Changed 6 days ago by beastr0

So Teor (or anyone else who's reading this and knows), how and where do I upload these patches?

comment:10 Changed 6 days ago by teor

You can attach them to this ticket using the "Attachments" button near the top of the ticket.
(If you don't see it, let me know, and I will enable it for you.)

Or you can clone https://git.torproject.org/tor.git , create a new branch, commit the patches to that branch, and push the branch to GitHub or a similar public repository.

Note: See TracTickets for help on using tickets.