Opened 7 months ago

Closed 7 months ago

#24859 closed defect (fixed)

Bug: Non-fatal assertion !(ent == NULL) failed in store_multiple at src/or/consdiffmgr.c

Reported by: dgoulet Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay, consdiff, 031-backport, 032-backport, review-group-31
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

During an heavy DoS on my relay, it ran out of RAM and disk space which I believe might have triggered this assert:

Dec 16 17:37:47.562 [warn] Error writing to "/home/tor/diff-cache/1224": Disk quota exceeded
Dec 16 17:37:47.562 [warn] tor_bug_occurred_(): Bug: src/or/consdiffmgr.c:1316: store_multiple: Non-fatal assertion !(ent == NULL) failed. (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug: Non-fatal assertion !(ent == NULL) failed in store_multiple at src/or/consdiffmgr.c:1316. Stack trace: (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /root/git/tor/src/or/tor(log_backtrace+0x42) [0x55994d4a8382] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /root/git/tor/src/or/tor(tor_bug_occurred_+0xb9) [0x55994d4c3619] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /root/git/tor/src/or/tor(+0x11a0c2) [0x55994d43e0c2] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /root/git/tor/src/or/tor(+0x11a7de) [0x55994d43e7de] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /root/git/tor/src/or/tor(replyqueue_process+0x51) [0x55994d4ca3c1] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x819) [0x7f800d7404c9] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /root/git/tor/src/or/tor(do_main_loop+0x24f) [0x55994d37726f] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /root/git/tor/src/or/tor(tor_run_main+0x265) [0x55994d3786f5] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /root/git/tor/src/or/tor(tor_main+0x3a) [0x55994d371f4a] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /root/git/tor/src/or/tor(main+0x19) [0x55994d371cb9] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7f800c65f830] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)
Dec 16 17:37:47.563 [warn] Bug:     /root/git/tor/src/or/tor(_start+0x29) [0x55994d371d09] (on Tor 0.3.3.0-alpha-dev 424572ee0a161428)

Child Tickets

Change History (5)

comment:1 Changed 7 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 7 months ago by nickm

Keywords: 031-backport 032-backport added
Status: acceptedneeds_review

Patch in my bg24859_031.

comment:3 Changed 7 months ago by nickm

Keywords: review-group-31 added

comment:4 Changed 7 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

This lgtm but I have a quick question.

If we do run out of space, is this log statement will spam like crazy or it should be in a reasonable amount? If too crazy, we should ratelimit or just get rid of it?

+        log_warn(LD_FS, "Unable to store object %s compressed with %s.",
+                 description, methodname);

comment:5 Changed 7 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

good point. I've merged to 0.3.1 and forward, adding a rate-limiter.

Note: See TracTickets for help on using tickets.