Opened 8 days ago

Last modified 4 days ago

#24879 needs_revision task

Set 'fetch: 1' by default for nightly builds

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201801
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


In tor-browser-build, when doing some build, we fetch new commits/branchs/tags from a git repository when the git revision specified in git_hash does not exist in the local repository. If the revision already exist, we don't update the repository. This means that if git_hash is pointing to a branch like master and the master branch already exists, it won't be updated. This can be confusing for the nightly builds, where you have to remember to run make fetch first if you want to build the very latest nightly, and not a nightly based on the commits from the last make fetch.

To avoid that we can set fetch: 1 for nightly in rbm.conf so that git repositories are updated for each build by default. People who don't want that can still change it in their rbm.local.conf.

Child Tickets

Change History (2)

comment:1 Changed 5 days ago by boklm

Keywords: TorBrowserTeam201801R added; TorBrowserTeam201801 removed
Status: newneeds_review

comment:2 Changed 4 days ago by gk

Keywords: TorBrowserTeam201801 added; TorBrowserTeam201801R removed
Status: needs_reviewneeds_revision

It seems to me we want to have the comment block in rbm.local.conf indented by another 2 chars?

Note: See TracTickets for help on using tickets.