Opened 9 months ago

Closed 8 months ago

#24885 closed defect (fixed)

Hide the HSDir and Guard flags on bridges in Relay Search

Reported by: teor Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #24817 Points:
Reviewer: Sponsor:

Description

They are meaningless for bridges, see #24817.

Child Tickets

Change History (6)

comment:1 Changed 9 months ago by irl

Component: Metrics/Relay SearchMetrics/Onionoo

This would be better solved in Onionoo, this way it only needs to be fixed once and new tools would already be doing the right thing.

comment:2 Changed 9 months ago by irl

Summary: Hide the HSDir and Guard flags on bridges on Relay SearchHide the HSDir and Guard flags on bridges

comment:3 Changed 9 months ago by teor

No, I'm sorry, this is tool-specific.

For example, metrics bot might want to hide the exit flag on bridges to avoid confusing casual viewers.
But relay search might not, because it's important we know when bridges have an exit policy (because it's weird).
And a detailed analysis tool might want to show all the flags, because it wants the actual bridge networkstatus contents.

So I think this decision really does belong with each tool.
If you agree, please fix the tickets.

comment:4 Changed 9 months ago by karsten

Component: Metrics/OnionooMetrics/Relay Search

I think I agree with teor here. It might depend on the tool which flags are relevant and which are not. I'd rather not want us to mess with them in Onionoo and include whatever we find in the bridge network status. Re-assigning to Relay Search.

comment:5 Changed 9 months ago by teor

Summary: Hide the HSDir and Guard flags on bridgesHide the HSDir and Guard flags on bridges in Relay Search

comment:6 Changed 8 months ago by irl

Resolution: fixed
Status: newclosed

Fixed in 5473806.

The only odd thing this now causes that before was less confusing is that you can search for "type:bridge flag:guard" and get a full set of responses that don't have the guard flag shown (same for hsdir).

Relay Search currently makes an effort to not parse the search query and let Onionoo do that. I don't want to add any query parsing to Relay Search.

If this behaviour is more confusing than the previous behaviour (I think it's probably OK) then please reopen the ticket.

Note: See TracTickets for help on using tickets.