Opened 6 months ago

Closed 6 weeks ago

#24891 closed defect (fixed)

build system --disable-unittests has no effect

Reported by: starlight Owned by: rl1987
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.1-alpha
Severity: Normal Keywords: 034-triage-20180328, 034-removed-20180328, 029-backport, 031-backport, 032-backport
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: isis Sponsor: Sponsor8-can

Description

While I applaud the explosion of unit test code in recent versions, I do not possess the hardware resources or time for running them and am unlikely to ever do so. To the extent that one would run tests, it's no problem at all to explicitly build them as needed.

Please cause the --disable-unittests option of configure to function as one would expect. Building test code takes a long time and I see no obvious Makefile hack to turn it off.

Child Tickets

Change History (11)

comment:1 Changed 6 months ago by nickm

Milestone: Tor: 0.3.4.x-final

comment:2 Changed 4 months ago by nickm

Keywords: 034-triage-20180328 added

comment:3 Changed 4 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:4 Changed 4 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:5 Changed 7 weeks ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:6 Changed 7 weeks ago by rl1987

Status: acceptedneeds_review

comment:7 Changed 7 weeks ago by dgoulet

Reviewer: nickm

comment:8 Changed 7 weeks ago by asn

Reviewer: nickmmikeperry

comment:9 Changed 7 weeks ago by isis

Keywords: 029-backport added
Milestone: Tor: unspecifiedTor: 0.3.4.x-final
Points: 1
Reviewer: mikeperryisis
Sponsor: Sponsor8-can
Version: Tor: 0.3.2.9Tor: 0.2.5.1-alpha

LGTM! Thanks rl1987!

It seems Mike and I both got assigned this ticket for review this week, which I'm assuming was a typo on the assignment spreadsheet. Since I already got to it, I'm removing Mike and adding myself, but Mike you should feel free to add yourself back in if you want to review as well.

I'm nominating this for backport to 0.2.9.

comment:10 Changed 6 weeks ago by dgoulet

Keywords: 031-backport 032-backport added
Status: needs_reviewmerge_ready

Adding 031 and 032 backport keyword considering this might be going back to 029.

comment:11 Changed 6 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

LGTM, and merging to master, but I'm going to say "no backport" -- apparently nobody had noticed that this was nonfunctional between 0.2.9 and now.

Note: See TracTickets for help on using tickets.