Opened 2 years ago

Closed 2 years ago

#24896 closed enhancement (implemented)

Onion services should include basic intro/rend stats in their heartbeat logs

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


In the periodic heartbeat messages, if I have one or more onion services configured, I want to hear (a) how many INTRODUCE2 cells I received since the last heartbeat, and (b) how many times circuit_launch_by_extend_info() got called with purpose CIRCUIT_PURPOSE_S_CONNECT_REND since the last heartbeat. These stats would have helped to discover #24894 and #24895.

There's probably a good argument for also hearing "(c) how many times we successfully established a joined rendezvous circuit", but that turns out to actually be a bit hard to track, since it looks like there's no explicit "it worked" acknowledgement in our protocol (whoops). We could approximate it with "number of times we sent a RENDEZVOUS1 cell, and the next cell we got in response was not an END cell with reason END_CIRC_REASON_TORPROTOCOL"?

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by asn

Status: newneeds_review

Pushed branch in my bug24896 that implements a basic version of this feature (does not actually do (c) from arma above).

This is the basic feature; in the future we can build more stuff and logic into it. The current version can still be helpful in giving a rough estimate of onion service usage, and also showing signs of abnormal activity.

comment:2 Changed 2 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

lgtm; merging

Note: See TracTickets for help on using tickets.