Changes between Initial Version and Version 1 of Ticket #24898, comment 2


Ignore:
Timestamp:
Jan 15, 2018, 8:29:10 AM (3 years ago)
Author:
arma
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24898, comment 2

    initial v1  
    11Right now, in channel_tls_process_netinfo_cell(), for the OR_CONN_STATE_OR_HANDSHAKING_V3 case, we call channel_mark_client() properly.
    22
    3 I propose that we call everything a client that handshakes with OR_CONN_STATE_OR_HANDSHAKING_V1 or OR_CONN_STATE_OR_HANDSHAKING_V2, since relays should never use those legacy handshakes with other relays at this point.
     3I propose that we call everything a client that handshakes with tor_tls_used_v1_handshake() or OR_CONN_STATE_OR_HANDSHAKING_V2, since relays should never use those legacy handshakes with other relays at this point.
    44
    55And then we can happily remove the dangerous clause from command.c.