Changes between Version 3 and Version 4 of Ticket #24902, comment 44


Ignore:
Timestamp:
Jan 29, 2018, 9:37:36 AM (4 months ago)
Author:
arma
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24902, comment 44

    v3 v4  
    99(It still won't be totally accurate, since whenever you get a create cell you'll call this refill function and discard the "fractional" circuit that you didn't add to the bucket. But I think that's ok.)
    1010
    11 Edit: I am still totally fine dropping the "tenths" notion and just having circuit_rate be in whole numbers -- especially given that if we're getting 1 create cell each second, then we're going to be rounding down each second anyway, so the tenths notion only really kicks in when many seconds go by between create cells, and those aren't the scary situations.
     11Edit: I am still totally fine dropping the "tenths" notion and just having circuit_rate be in whole numbers -- especially given that if we're getting at least 1 create cell each second, then we're going to be rounding down each second anyway, so the tenths notion only really kicks in when many seconds go by between create cells, and those aren't the scary situations.
    1212
    1313Edit edit: I guess you could also make the buckets themselves be in tenths. And then subtract 10 from the bucket each time you handle a circuit. Then you could accumulate multiple fractions of a circuit over time, and the calculations over time would be more accurate. But I remain fine with the simpler whole number approach. :)