Opened 7 months ago

Closed 5 months ago

#24904 closed defect (implemented)

Make geoip use channel_is_client so it ignores flapping relays

Reported by: teor Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy, intro, refactor, technical-debt, tor-stats, 033-must, 033-triage-20180320, 033-included-20180320
Cc: Actual Points:
Parent ID: #23423 Points: 0.5
Reviewer: nickm Sponsor:

Description

In channel_do_open_actions(), we probably want to use channel_is_client() rather than connection_or_digest_is_known_relay().

    /* only report it to the geoip module if it's not a known router */
    if (!connection_or_digest_is_known_relay(chan->identity_digest)) {
      if (channel_get_addr_if_possible(chan, &remote_addr)) {

Bugfix on #23533, 0.3.0.1-alpha.

We should make sure #24898 is fixed in any version we backport this to.

Child Tickets

Change History (13)

comment:1 Changed 7 months ago by arma

Agreed.

My commit f5ff9f23 in my bug24898-more branch has this fix. Feel free to pull it out into its own fix and its own commit if you want that.

comment:2 Changed 7 months ago by arma

Status: newneeds_review

comment:3 Changed 7 months ago by arma

Milestone: Tor: 0.3.4.x-finalTor: 0.3.3.x-final

comment:4 Changed 7 months ago by teor

Status: needs_reviewneeds_revision

comment:5 Changed 7 months ago by teor

This is fine, but it needs to be split into its own commit.
(Or all the other code in the commit needs to be fixed.)

comment:6 Changed 6 months ago by dgoulet

Keywords: 033-must added

Some ticket dgoulet thinks must go in 033.

comment:7 Changed 5 months ago by nickm

Keywords: 033-triage-20180320 added

Marking all tickets reached by current round of 033 triage.

comment:8 Changed 5 months ago by nickm

Keywords: 033-included-20180320 added

Mark 033-must tickets as triaged-in for 0.3.3

comment:9 Changed 5 months ago by dgoulet

Owner: set to dgoulet
Status: needs_revisionaccepted

Taking over this one so we can get it in 033 asap.

comment:10 Changed 5 months ago by dgoulet

Status: acceptedneeds_review

Taken from part of arma's commit f5ff9f23

See branch: bug24904_033_01

comment:11 Changed 5 months ago by dgoulet

Reviewer: nickm

Assign Reviewer to nickm for the 26/03/18 week.

comment:12 Changed 5 months ago by nickm

looks fine; merged to 0.3.3

comment:13 Changed 5 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.