Opened 21 months ago

Last modified 19 months ago

#24905 needs_revision defect

Remove redundant connection_or_digest_is_known_relay() from CHANNEL_IS_CLIENT

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.3.1.1-alpha
Severity: Normal Keywords: refactor, redundant, technical-debt, 033-triage-20180320, 033-removed-20180320
Cc: Actual Points:
Parent ID: #23423 Points:
Reviewer: Sponsor:

Description

After we fix #24898, we should fix this macro as well:

#define CHANNEL_IS_CLIENT(chan, options) \
  (!public_server_mode((options)) || channel_is_client(chan) || \
      !connection_or_digest_is_known_relay((chan)->identity_digest))

And we should rename it to something like CHANNEL_IS_CLIENT_AT_EITHER_END() to fix #22717.

Child Tickets

TicketStatusOwnerSummaryComponent
#22717assignedRename channelpadding.c's CHANNEL_IS_CLIENT to avoid confusionCore Tor/Tor

Change History (7)

comment:1 Changed 21 months ago by arma

Status: newneeds_review

Agreed.

My commit f5ff9f23 in my bug24898-more branch has this fix. Feel free to pull it out into its own fix and its own commit if you want that.

comment:2 Changed 21 months ago by arma

Milestone: Tor: 0.3.4.x-finalTor: 0.3.3.x-final

comment:3 Changed 21 months ago by teor

Status: needs_reviewneeds_revision

This is fine, but it needs to be split into its own commit.
(Or all the other code in the commit needs to be fixed.)

And it would be nice to do the rename at the same time.

comment:4 Changed 21 months ago by dgoulet

+1 on the rename, lets take this opportunity for this as it is really wrong to use the same name as the channel's function .

comment:5 Changed 19 months ago by nickm

Keywords: 033-triage-20180320 added

Marking all tickets reached by current round of 033 triage.

comment:6 Changed 19 months ago by nickm

Keywords: 033-removed-20180320 added

Mark all not-already-included tickets as pending review for removal from 0.3.3 milestone.

comment:7 Changed 19 months ago by nickm

Milestone: Tor: 0.3.3.x-finalTor: unspecified

These tickets were marked as removed, and nobody has said that they can fix them. Let's remember to look at 033-removed-20180320 as we re-evaluate our triage process, to see whether we're triaging out unnecessarily, and to evaluate whether we're deferring anything unnecessarily. But for now, we can't do these: we need to fix the 033-must stuff now.

Note: See TracTickets for help on using tickets.