Opened 21 months ago

Last modified 18 months ago

#24907 needs_revision defect

Stop ignoring should_refuse_unknown_exits() for unauthenticated channels

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.3.1.1-alpha
Severity: Normal Keywords: easy, intro, regression, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: #23423 Points: 0.5
Reviewer: Sponsor:

Description

The brackets in this code are wrong in at least two ways:

  • they unconditionally reject client channels
  • there are two at the start
      if ((client_chan ||
           (!connection_or_digest_is_known_relay(
                or_circ->p_chan->identity_digest) &&
          should_refuse_unknown_exits(options)))) {

Bugfix on d52a1e2 in #22060, note that 66aff2d was merged into that code in 0.3.2.

Child Tickets

TicketStatusOwnerSummaryComponent
#24903closednickmBug: Line unexpectedly reached at pathbias_should_count at src/or/circpathbias.c:372Core Tor/Tor

Change History (6)

comment:1 Changed 21 months ago by arma

Hm! You're right that is currently unconditionally refuses exits from client channels. I am actually kind of ok with that behavior, but you're right our documentation very clearly says how it ought to work (and it doesn't work that way now).

My f5ff9f2 commit does a start at fixing this ticket but does not go far enough.

comment:2 Changed 21 months ago by teor

Status: newneeds_revision

comment:3 Changed 21 months ago by teor

Parent ID: #23423

comment:4 Changed 19 months ago by nickm

Keywords: 034-triage-20180328 added

comment:5 Changed 19 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:6 Changed 18 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These needs_revision, tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if somebody does the necessary revision.

Note: See TracTickets for help on using tickets.