Opened 8 months ago

Closed 6 months ago

#24910 closed defect (fixed)

Make rep_hist_note_circuit_handshake_* use channel_is_client()

Reported by: teor Owned by: arma
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: refactor, redundant, technical-debt, 033-triage-20180320, 033-removed-20180320, fast-fix
Cc: Actual Points:
Parent ID: #23423 Points:
Reviewer: Sponsor:

Description

This is in arma's commit f5ff9f23 in his bug24898-more branch.

Child Tickets

Change History (8)

comment:1 Changed 8 months ago by teor

Status: newneeds_revision

These changes are fine, but we need to fix the rest of the commit.

comment:2 Changed 6 months ago by nickm

Keywords: 033-triage-20180320 added

Marking all tickets reached by current round of 033 triage.

comment:3 Changed 6 months ago by nickm

Keywords: 033-removed-20180320 added

Mark all not-already-included tickets as pending review for removal from 0.3.3 milestone.

comment:4 Changed 6 months ago by nickm

Milestone: Tor: 0.3.3.x-finalTor: unspecified

These tickets were marked as removed, and nobody has said that they can fix them. Let's remember to look at 033-removed-20180320 as we re-evaluate our triage process, to see whether we're triaging out unnecessarily, and to evaluate whether we're deferring anything unnecessarily. But for now, we can't do these: we need to fix the 033-must stuff now.

comment:5 Changed 6 months ago by arma

Owner: set to arma
Status: needs_revisionassigned

comment:6 Changed 6 months ago by arma

Keywords: fast-fix added
Status: assignedneeds_review

See my bug24910 branch for the fix.

It's on master, so targeted to 0.3.4. Feel free to target to 0.3.3 if you prefer that (it's one commit so easy to move around).

comment:7 Changed 6 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.3.x-final

comment:8 Changed 6 months ago by nickm

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final
Resolution: fixed
Status: needs_reviewclosed

Taking in 0.3.4. Thanks, Roger!

Note: See TracTickets for help on using tickets.