Opened 2 years ago

Closed 12 months ago

#24919 closed defect (wontfix)

Orfox still prompts for enabling Sync

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile
Cc: igt0 Actual Points:
Parent ID: #5709 Points:
Reviewer: Sponsor:

Description

This may be in mobile.js, but needs further investigation.

In particular, on the about:home (not private) Orfox shows a popup for configuring Sync. I haven't found steps for reproducing, I've only seen it a few times.

Child Tickets

Change History (8)

comment:1 Changed 2 years ago by gk

Keywords: tbb-mobile added

comment:2 Changed 2 years ago by sysrqb

Okay, found it. The text is: "Sync is brand new and easier than ever". This is created in mobile/android/components/Snippets.js:loadSyncPromoBanner()

It seems this is called after Gecko starts in mobile/android/chrome/content/browser.js when the browser-delayed-startup-finished topic is notified. We may need clean sync references in browser.js...

comment:3 Changed 23 months ago by sysrqb

Parent ID: 19675

comment:4 Changed 23 months ago by sysrqb

Parent ID: 19675#19675

comment:5 Changed 22 months ago by sysrqb

Parent ID: #19675#5709

Moving these to #5709, these aren't blockers anymore. We'll merge Orfox patches first, then audit everything as we move to m-c and work on TBA. (We should create more tickets as we find more items that need investigating/fixing)

comment:6 Changed 20 months ago by sysrqb

The current plan, as I understand it, is we disable Sync (at compile-time) until we sufficiently audit the implementation and decide it is proxy-safe. We'll allow Sync after that time. Sync is already mostly disabled in Orfox, but the UI is still confusing so we should improve that - and ensure it is actually not available.

comment:7 Changed 20 months ago by gk

I wonder if https://hg.mozilla.org/mozilla-central/rev/109cd0a34ffe helps here as well? If not I guess adding to that patch to fix the remaining mobile bits is the way to go.

comment:8 Changed 12 months ago by gk

Resolution: wontfix
Status: newclosed

We are closer to moving Orfox users to Tor Browser for Android. We therefore won't spend time investigatig and fixing Orfox bugs anymore.

Note: See TracTickets for help on using tickets.