Opened 13 months ago

Closed 5 weeks ago

#24953 closed defect (fixed)

In check_existing mode, log "fallback list", not "whitelist"

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Fallback Scripts Version: Tor: 0.3.0.3-alpha
Severity: Normal Keywords: fast-fix, fallback, 034-triage-20180328, 034-removed-20180328, 035-triaged-in-20180711
Cc: rl1987 Actual Points:
Parent ID: Points: 0.2
Reviewer: teor Sponsor:

Description

This confused at least one relay operator.

Child Tickets

Change History (17)

comment:1 Changed 11 months ago by nickm

Keywords: 034-triage-20180328 added

comment:2 Changed 11 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:3 Changed 11 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:4 Changed 10 months ago by teor

Keywords: fast-fix added
Milestone: Tor: unspecifiedTor: 0.3.4.x-final

This is a really fast fix, so let's do it in 0.3.4.

comment:5 Changed 10 months ago by teor

Milestone: Tor: 0.3.4.x-finalTor: 0.3.5.x-final

8/150 = 5% of fallbacks are currently down.
https://consensus-health.torproject.org/graphs.html
At this rate, it will be 2019 before we reach our 25% failure threshold.
So we don't need to do a fallback rebuild in 0.3.4.

comment:6 Changed 8 months ago by teor

Parent ID: #24786

We don't need to do this ticket as part of the rebuild.

comment:7 Changed 8 months ago by teor

Cc: teor@… removed

Remove useless CC

comment:8 Changed 7 months ago by nickm

Keywords: 035-triaged-in-20180711 added

comment:9 Changed 6 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.6.x-final

comment:10 Changed 3 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

comment:11 Changed 6 weeks ago by rl1987

Status: newneeds_review

comment:12 Changed 6 weeks ago by teor

Status: needs_reviewneeds_revision

Thanks for this patch.

These changes are good, but we want to use "whitelist" in the default mode, and "fallback list" in check_existing mode.
(The script can run in two modes: https://github.com/torproject/tor/blob/master/scripts/maint/updateFallbackDirs.py#L5 )

This is how the modes are implemented:
https://github.com/torproject/tor/blob/master/scripts/maint/updateFallbackDirs.py#L2210
You could add a "type" key to the "whitelist" dictionary, and then use it in the strings.

We also need to change "whitelist" in summarise_fallbacks:
https://github.com/torproject/tor/blob/master/scripts/maint/updateFallbackDirs.py#L2206

comment:13 Changed 6 weeks ago by rl1987

Cc: rl1987 added
Status: needs_revisionneeds_review

Tried addressing these in 08921df6a2daa18729d9f3012d724d7ecb65883d.

comment:14 Changed 6 weeks ago by teor

Reviewer: teor
Status: needs_reviewneeds_revision
Version: Tor: 0.3.0.3-alpha

We're almost there, I left a few comments on the pull request.

comment:15 Changed 6 weeks ago by rl1987

Status: needs_revisionneeds_review

comment:16 Changed 5 weeks ago by mikeperry

Status: needs_reviewmerge_ready

These final fixups addressed Teor's comments.

comment:17 Changed 5 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

squashed and merged!

Note: See TracTickets for help on using tickets.