Opened 2 years ago

Closed 2 years ago

#24954 closed defect (fixed)

Metrics performance measurements use v2 onion services

Reported by: teor Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords: easy, intro
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


I missed these when we did the original v2/v3 onion service update:

They should both say "v2 onion" in their description, or maybe the data selection label.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by karsten

Makes sense. Want to write a patch for the description?

comment:2 Changed 2 years ago by karsten

Owner: changed from metrics-team to karsten
Status: newaccepted

Or otherwise I'll do it.

comment:3 Changed 2 years ago by karsten

Status: acceptedneeds_review

Please review commit a3dd5b4 in my task-24954 branch. I edited the two graph descriptions and the CSV file specification, but I'm not sure if the new text is too complex now. Want to take a look and possibly tweak that text?

Regarding the data selection label, I'd like to leave that as is, at least as long as we're only measuring v2 onion services. Of course, if we start measuring v3 onion services, we should rename that label to "v2 onion" and create a new "v3 onion" label. We're not there yet, though.

comment:4 Changed 2 years ago by teor

Status: needs_reviewmerge_ready

Thanks for doing this patch, I haven't had much volunteer coding time lately.
Looks fine to me.

comment:5 Changed 2 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Thanks for taking a look! Merged to master and deployed. Closing.

Note: See TracTickets for help on using tickets.