Opened 3 years ago

Closed 3 years ago

#24961 closed defect (invalid)

Authorities crash in Shadow with because it's 1970 due to new HS code

Reported by: pastly Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords:
Cc: robgjansen, ahf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


(I'm still fact checking this ticket if this parenthetical is still here)

hs_get_time_period_num is called in the first 3 minutes of a Shadow simulation.

Shadow starts time at the unix epoch. So the function would ultimately calculate it is time period zero if it wasn't for a fatal assert in the middle of the function preventing that from happening.

I like the idea of inflating time period numbers, perhaps with a better-thought-out version of this patch

I've also been talking to Rob about time keeping in Shadow, and it actually may not end up being that bad starting time at, say, y2k instead of 1970.

So I'm not sure what codebase *should* get fixed at this time.

Child Tickets

Change History (1)

comment:1 Changed 3 years ago by pastly

Resolution: invalid
Status: newclosed

Fixing this in Shadow.

Note: See TracTickets for help on using tickets.