Opened 11 months ago

Last modified 8 months ago

#24966 new defect

Silence warnings for circuits created from controller

Reported by: tom Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: regression?, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

The new bwscanner is generating these log lines:

Jan 22 20:10:16.000 [warn] circuit_build_no_more_hops(): Bug: 2-hop circuit 0x55e5b007a260 with purpose 5 has no guard state (on Tor 0.3.2.9 )
2018-01-22T20:10:16-0600 [INFO]: Downloading file '4M' over [$B93E04EB7BC1B058593A403482C1DF8BE76671C6, $71F85FEE1922E2287F2491CF67E23F20B1C51FBB].
Jan 22 20:10:16.000 [notice] pathbias_count_use_attempt(): Bug: Used circuit is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:16.000 [warn] circuit_build_no_more_hops(): Bug: 2-hop circuit 0x55e5b00720e0 with purpose 5 has no guard state (on Tor 0.3.2.9 )
Jan 22 20:10:16.000 [notice] pathbias_count_use_attempt(): Bug: Used circuit is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
2018-01-22T20:10:16-0600 [INFO]: Downloading file '2M' over [$FB911FA42CC7513AA2F662C217AE1D4426BB1231, $6ED1509C5DF83DBD896CE617E87550A682A5741D].
Jan 22 20:10:16.000 [notice] pathbias_mark_use_success(): Bug: Used circuit 16 is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:16.000 [notice] pathbias_count_use_attempt(): Bug: Used circuit is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:16.000 [warn] circuit_build_no_more_hops(): Bug: 2-hop circuit 0x55e5b0087700 with purpose 5 has no guard state (on Tor 0.3.2.9 )
Jan 22 20:10:16.000 [notice] pathbias_count_use_attempt(): Bug: Used circuit is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [warn] circuit_build_no_more_hops(): Bug: 2-hop circuit 0x55e5b00b42a0 with purpose 5 has no guard state (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [notice] pathbias_count_use_attempt(): Bug: Used circuit is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [warn] circuit_build_no_more_hops(): Bug: 2-hop circuit 0x55e5b0072730 with purpose 5 has no guard state (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [notice] pathbias_count_use_attempt(): Bug: Used circuit is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [notice] pathbias_mark_use_success(): Bug: Used circuit 22 is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [notice] pathbias_count_use_attempt(): Bug: Used circuit is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [warn] circuit_build_no_more_hops(): Bug: 2-hop circuit 0x55e5b00837a0 with purpose 5 has no guard state (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [notice] pathbias_count_use_attempt(): Bug: Used circuit is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [notice] pathbias_mark_use_success(): Bug: Used circuit 19 is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [notice] pathbias_count_use_attempt(): Bug: Used circuit is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [warn] circuit_build_no_more_hops(): Bug: 2-hop circuit 0x55e5b00aabc0 with purpose 5 has no guard state (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [notice] pathbias_count_use_attempt(): Bug: Used circuit is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [notice] pathbias_mark_use_success(): Bug: Used circuit 14 is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )
Jan 22 20:10:17.000 [notice] pathbias_count_use_attempt(): Bug: Used circuit is in strange path state new. Circuit is a General-purpose client currently open. (on Tor 0.3.2.9 )

Child Tickets

Change History (4)

comment:1 Changed 11 months ago by teor

Keywords: regression? added
Milestone: Tor: 0.3.4.x-final
Points: 0.5

There are a few bugs here:

  • circuit_purpose_may_omit_guard() should probably return 1 for CIRCUIT_PURPOSE_CONTROLLER (bug on 0.3.0.1-alpha)
  • Maybe we should unify pathbias_should_count() and circuit_purpose_may_omit_guard(), or at least make them more consistent (bug on 0.3.0.1-alpha)

But the underlying bug is that pathbias_should_count() wants to know if the circuit was created by a controller. There is no flag for this: instead, it checks if the circuit has a controller purpose right now (bug on 0.2.4).

comment:2 Changed 9 months ago by nickm

Keywords: 034-triage-20180328 added

comment:3 Changed 9 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:4 Changed 8 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.