#24967 closed defect (fixed)

torsocks fails to check SIP if the path itself is a symlink

Reported by: Hello71 Owned by: Hello71
Priority: Medium Milestone:
Component: Core Tor/Torsocks Version:
Severity: Major Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

suppose /a -> /usr/bin, and /b -> /usr/bin/b. torsocks will error on /a/b, but /b will simply fail to apply torsocks (I think). I have a patch for this, will clean up and submit some time in the next few days hopefully.

Child Tickets

Change History (10)

comment:1 Changed 23 months ago by Hello71

Owner: changed from dgoulet to Hello71
Status: newassigned

comment:2 Changed 23 months ago by Hello71

Status: assignedneeds_review

comment:3 Changed 23 months ago by ahf

As this patch touches some paths that are only executed on macos I'll give it a round of testing later today.

comment:4 Changed 20 months ago by dgoulet

Status: needs_reviewneeds_revision

This breaks on my Linux with:

ERROR: /lib/torsocks/libtorsocks.so does not exist! Try re-installing torsocks.

It should actually be /usr/local/lib/torsocks/... in my case.

comment:5 in reply to:  4 Changed 20 months ago by Hello71

Replying to dgoulet:

This breaks on my Linux with:

ERROR: /lib/torsocks/libtorsocks.so does not exist! Try re-installing torsocks.

It should actually be /usr/local/lib/torsocks/... in my case.

how odd. I know that the full path in autotools should be @prefix@/@libdir@, but in this patch I literally expanded the existing definition. did the old version work for you?

comment:6 Changed 14 months ago by Hello71

Status: needs_revisionneeds_information

comment:7 Changed 14 months ago by Hello71

fyi dgoulet I need information from you, not from myself :)

comment:8 Changed 14 months ago by dgoulet

Not sure what you mean by the "old version" but torsocks always works out from git repo for me as it is the only thing I use (master branch).

comment:9 Changed 14 months ago by Hello71

Status: needs_informationneeds_review

OK, I reverted the SHLIB changes and fixed a typo.

comment:10 Changed 13 months ago by dgoulet

Resolution: fixed
Status: needs_reviewclosed

I've merged 96e57d8ddc9339f4 upstream (from your repo).

Note: See TracTickets for help on using tickets.