#24969 closed defect (fixed)

Allow sleep() in the sandbox

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.1-alpha
Severity: Normal Keywords: tor-crash, 034-triage-20180328, 034-must fast-fix crash 029-backport 031-backport 032-backport 033-backport
Cc: Actual Points: 0
Parent ID: Points: 0.2
Reviewer: dgoulet Sponsor:

Description

try_locking() will sleep() if there is another Tor instance using the data directory. If the sandbox is enabled, this will cause Tor to crash.

Child Tickets

Change History (8)

comment:1 Changed 12 months ago by nickm

Keywords: 034-triage-20180328 added

comment:2 Changed 12 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:3 Changed 12 months ago by nickm

Keywords: 034-must fast-fix crash added; 034-removed-20180328 removed
Owner: set to nickm
Status: newaccepted

comment:4 Changed 11 months ago by nickm

Actual Points: 0
Keywords: 029-backport 031-backport 032-backport 033-backport added
Status: acceptedneeds_review

Trivial fix in bug24969_029.

comment:5 Changed 11 months ago by dgoulet

Status: needs_reviewneeds_revision

Commit message and changes file do not mention:

+#ifdef __NR_prlimit
+    SCMP_SYS(prlimit),
+#endif

Sure we want it in? If so, I would just document it.

comment:6 Changed 11 months ago by nickm

Status: needs_revisionneeds_review

no, the prlimit thing was just a copy-paste error.

Updated patch in bug24969_029_v2.

comment:7 Changed 11 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm;

comment:8 Changed 11 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: 0.2.9.x-final
Resolution: fixed
Status: merge_readyclosed

Merged to 0.2.9 and forward.

Note: See TracTickets for help on using tickets.