#24995 closed defect (fixed)

Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9

Reported by: TheDcoder Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201802R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hello,

From latest build of the Expert Bundle (Tor 0.3.2.9) available on the website, the tor.exe binary doesn't show/have the truncated git hash in the version, here is the console output:

E:\Software\ProxAllium\Tor>tor.exe --version
Tor version 0.3.2.9.

In the previous build/release of the Expert Bundle (Tor 0.3.1.9), there used to be a truncated git hash in the version string:

E:\Projects\AutoIt\ProxAllium\Builds\v0.3-beta\ProxAllium\Tor>tor.exe --version
Tor version 0.3.1.9 (git-727d3f1b5e6eeda7).

It might be related to the latest change in Tor Browser's build system switch from gitian/tor-browser-bundle to rbm/tor-browser-build.

Child Tickets

Change History (8)

comment:1 Changed 10 months ago by arma

Summary: Truncated git hash not available in the build for Tor 0.3.2.9Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9

comment:2 Changed 10 months ago by boklm

Ah yes, it is probably because with rbm/tor-browser-build the .git directory is not available anymore when we do the build.

I think we could fix that by adding the hash in the file micro-revision.i during the build.

comment:3 Changed 10 months ago by gk

Keywords: tbb-rbm added
Version: Tor: 0.3.2.9

comment:4 Changed 10 months ago by boklm

Keywords: TorBrowserTeam201801R added
Status: newneeds_review

I pushed a patch to fix that in branch bug_24995_v2:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_24995_v2&id=ab4a36dc316968cd3f87f4dace6e9983508bebb9

After building an Expert Bundle with:

./rbm/rbm build --target alpha --target torbrowser-windows-i686 --target expert-bundle tor

The git hash is again in the tor.exe --version output.

comment:5 Changed 10 months ago by boklm

Status: needs_reviewneeds_revision

We should fix #25004 first.

comment:6 Changed 10 months ago by gk

Keywords: TorBrowserTeam201801 added; TorBrowserTeam201801R removed

comment:7 Changed 10 months ago by boklm

Keywords: TorBrowserTeam201802R added; TorBrowserTeam201801 removed
Status: needs_revisionneeds_review

There is a new version of the patch in branch bug_24995_v3, using abbrev_length instead of abbrev_lenght:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_24995_v3&id=c873b63900021e29f7ac01c92145e91a7cb64fff

comment:8 Changed 10 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, thanks. Merged to master (commit c873b63900021e29f7ac01c92145e91a7cb64fff).

Note: See TracTickets for help on using tickets.