#24996 closed defect (fixed)

OnionPerf showing >200% timeouts

Reported by: irl Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Statistics Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: iwakeh Sponsor:

Description

https://metrics.torproject.org/torperf-failures.html

This doesn't make a lot of sense. Either it's incorrect or it's poorly explained.

Child Tickets

Attachments (1)

torperf-failures-public-2017-10-26-2018-01-24-all-50kb.png (53.1 KB) - added by irl 17 months ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 17 months ago by karsten

Owner: changed from metrics-team to karsten
Status: newaccepted

True. I'll take a look.

comment:2 Changed 17 months ago by karsten

Status: acceptedneeds_review

It looks like we implemented the database query for filling the "requests" column in the underlying CSV file as completed requests and later used the data in the graph as if it contained total requests made. The latter definition is also what we wrote in the specification, so I'd say let's change the database query. At least I can't come up with a good reason for keeping the current implementation.

Please review commit 0340088 in my task-24996 branch with a small fix. If that looks okay, I can deploy it easily on the server, and the next module run will fix the CSV file and graph.

comment:3 Changed 17 months ago by iwakeh

Reviewer: iwakeh

Added to my review list.

comment:4 Changed 17 months ago by iwakeh

Status: needs_reviewmerge_ready

Fine to be merged.

comment:5 Changed 17 months ago by karsten

Thanks for looking, merged! Starting a new module run now. We'll see in a few hours if this fixed the issue.

comment:6 Changed 17 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

This is now fixed. Closing. Thanks!

Note: See TracTickets for help on using tickets.