Opened 9 years ago

Closed 9 years ago

#2500 closed defect (fixed)

Bandwidth-graph setting partially not shown with some languages

Reported by: bastik Owned by: chiiph
Priority: Low Milestone: Vidalia: 0.2.13
Component: Archived/Vidalia Version: Vidalia 0.2.10
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The last setting (Always on Top) of Vidalias' bandwidth-graph is not shown correctly. At least if the German language is selected, but I guess it affects other languages too.

In German "Always on Top" is translated to "Immer im Vordergrund", which is correct, but the "I" is missing and the first "m" is cut off. Resizing doesn't help.

I guess it affects other languages, too. It looks like a problem with the available space for the setting name.

I attach a screen shot to show you the problem.

ps: This is the fist time I dare to set the priority.

Child Tickets

Attachments (4)

Vidalia-bdw-letters.png (10.2 KB) - added by bastik 9 years ago.
vidalia.messagelog.patch (658 bytes) - added by chiiph 9 years ago.
Basically just puts the problematic groupbox inside a layout
bwgraph-before-after.png (36.2 KB) - added by edmanm 9 years ago.
Screenshot showing excessive vertical separation
vidalia.bwgraph.patch (27.3 KB) - added by chiiph 9 years ago.
Updated patch to handle vertical spacing right

Download all attachments as: .zip

Change History (14)

Changed 9 years ago by bastik

Attachment: Vidalia-bdw-letters.png added

Changed 9 years ago by chiiph

Attachment: vidalia.messagelog.patch added

Basically just puts the problematic groupbox inside a layout

comment:1 Changed 9 years ago by chiiph

Status: newneeds_review

comment:2 Changed 9 years ago by edmanm

Hm, looks like you attached the wrong patch to this ticket. The patch above is actually the one from ticket #2093.

comment:3 Changed 9 years ago by chiiph

Hm, this didn't send an notification when I uploaded the patch. (here it is)

comment:4 Changed 9 years ago by edmanm

I mostly like the patch, but it does screw up the vertical spacing between the window's status bar and the two bottom buttons. I'll attach screenshots showing the additional forced vertical separation between the buttons and the status bar. I didn't look into it much, but perhaps there's a spacer or something where there shouldn't be.

That said, the vertical spacing was a little wonky before anyway, so I guess the patch doesn't make things a whole lot worse than it was before.

Changed 9 years ago by edmanm

Attachment: bwgraph-before-after.png added

Screenshot showing excessive vertical separation

Changed 9 years ago by chiiph

Attachment: vidalia.bwgraph.patch added

Updated patch to handle vertical spacing right

comment:5 Changed 9 years ago by chiiph

Here's an updated patch that handles the vertical spacing by scaling the bandwidth graph only.

comment:6 Changed 9 years ago by edmanm

There was no perceptible change in the vertical separation with the latest patch.

If you want to commit this patch anyway, that's fine with me. It's probably tough to fix it if you don't have a Mac to test on. The layout was kinda ugly before anyway, so I can't fuss much if it gets just a little bit uglier on one platform.

comment:7 Changed 9 years ago by chiiph

Ok, I'll freeze this issue until I get the mac to test on (in a couple of weeks if everything goes right).

comment:8 Changed 9 years ago by arma

How's that mac arrival plan going? (Filling in for bastik, who is hoping to see progress on this ticket)

comment:9 in reply to:  8 Changed 9 years ago by chiiph

Replying to arma:

How's that mac arrival plan going? (Filling in for bastik, who is hoping to see progress on this ticket)

It isn't going. The mac arrived, and the custom's people basically told me that they were going to return it because I can't recieve used electronics from abroad. So I was discussing with Andrew about buying one in here, but there aren't any more news there either.

comment:10 Changed 9 years ago by chiiph

Milestone: Vidalia: 0.2.13
Resolution: fixed
Status: needs_reviewclosed

This has been fixed in commit 6b5b962442e64bfe5edc9b139778c3ba8e14c637 for master. It was tested in OSX and Linux.

This change will be available in 0.2.13, and 0.3.1-alpha.

Note: See TracTickets for help on using tickets.