Opened 3 years ago

Last modified 3 years ago

#25007 new enhancement

See if we can allocate less for HMAC in Tor relays

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: memory, performance, malloc, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: #23777 Points:
Reviewer: Sponsor:


Our HMAC usage accounts for a comparatively large fraction of our allocations, according to the data from #23777. Let's see if we can make it allocate less, since it's part of our critical path.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by nickm

We can almost certainly do better with our hkdf usage by using openssl's EVP_PKEY_HKDF where available.

Reusing an HMAC_CTX structure for other HMAC operations may also improve performance.

Last edited 3 years ago by nickm (previous) (diff)

comment:2 Changed 3 years ago by nickm

Keywords: 034-triage-20180328 added

comment:3 Changed 3 years ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:4 Changed 3 years ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.