Opened 9 months ago

Closed 9 months ago

#25009 closed defect (duplicate)

I think KIST can use hash tables much less.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 032-backport, tor-sched, kist
Cc: Actual Points:
Parent ID: #23777 Points:
Reviewer: Sponsor:

Description (last modified by nickm)

Originally, I observed that outbuf_table_add shows up in our malloc profile (#23777), where I hadn't been expecting to see it.

After a little more thinking, I'm wondering why we have outbuf_table and socket_table at all:

The contents of socket_table_ent could become a member of channel_t, and save us a hashtable lookup there.

The outbuf_table could become a smartlist with a corresponding index pointer in channel_t, since we're basically using it as an unordered set.

Child Tickets

Change History (4)

comment:1 Changed 9 months ago by nickm

Description: modified (diff)
Owner: set to nickm
Status: newaccepted
Summary: Can outbuf_table_add be made to allocate less?I think KIST can use hash tables much less.

comment:2 Changed 9 months ago by nickm

See also #24554

comment:3 Changed 9 months ago by dgoulet

Keywords: tor-sched kist added

Yes, it is known issue that has been addressed in #24554. However, it hasn't been planned for backport so maybe we could do a simple patch that fixes this massive amount of allocation and then port it to #24554.

comment:4 Changed 9 months ago by nickm

Resolution: duplicate
Status: acceptedclosed

Since #24554 removes both hashtables, this is a duplicate.

Note: See TracTickets for help on using tickets.