Opened 8 months ago

Closed 8 months ago

Last modified 7 months ago

#25016 closed defect (fixed)

Remove 2017 in-browser donation banner

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201801R, tbb-backported
Cc: Actual Points:
Parent ID: #23482 Points:
Reviewer: Sponsor:

Description

Now that the donation campaign is finished, we can remove the donation banner.

Child Tickets

Change History (4)

comment:1 Changed 8 months ago by arthuredelstein

Keywords: TorBrowserTeam2018R added; TorBrowserTeam2018 removed
Status: new → needs_review

Here is a patch for review:

​https://github.com/arthuredelstein/torbutton/commit/25016

The same patch on top of the maint-1.9.7 branch:

​https://github.com/arthuredelstein/torbutton/commit/f6fe17fe5dbfe7de2af8ad7021b560bbe11a8a53

comment:2 Changed 8 months ago by arthuredelstein

Keywords: TorBrowserTeam201801R added; TorBrowserTeam2018R removed

comment:3 Changed 8 months ago by gk

Resolution: → fixed
Status: needs_review → closed

Thanks, looks good to me. No need for a patch for maint-1.9.7 as we are using 1.9.8.X for the 7.5 series (there is no maint-1.9.8 branch yet). Thus, I just merged your changes to master (commit f96a293d146d3dc54f8ecfaa1d3dfc669bf4198d).

comment:4 in reply to:  3 Changed 7 months ago by gk

Keywords: tbb-backported added

Replying to gk:

Thanks, looks good to me. No need for a patch for maint-1.9.7 as we are using 1.9.8.X for the 7.5 series (there is no maint-1.9.8 branch yet). Thus, I just merged your changes to master (commit f96a293d146d3dc54f8ecfaa1d3dfc669bf4198d).

That's on maint-1.9.8 now, too.

Note: See TracTickets for help on using tickets.