#25016 closed defect (fixed)
Remove 2017 in-browser donation banner
Reported by: | arthuredelstein | Owned by: | tbb-team |
---|---|---|---|
Priority: | Medium | Milestone: | |
Component: | Applications/Tor Browser | Version: | |
Severity: | Normal | Keywords: | TorBrowserTeam201801R, tbb-backported |
Cc: | Actual Points: | ||
Parent ID: | #23482 | Points: | |
Reviewer: | Sponsor: |
Description
Now that the donation campaign is finished, we can remove the donation banner.
Child Tickets
Change History (4)
comment:1 Changed 13 months ago by
Keywords: | TorBrowserTeam2018R added; TorBrowserTeam2018 removed |
---|---|
Status: | new → needs_review |
comment:2 Changed 13 months ago by
Keywords: | TorBrowserTeam201801R added; TorBrowserTeam2018R removed |
---|
comment:3 follow-up: 4 Changed 13 months ago by
Resolution: | → fixed |
---|---|
Status: | needs_review → closed |
Thanks, looks good to me. No need for a patch for maint-1.9.7
as we are using 1.9.8.X for the 7.5 series (there is no maint-1.9.8
branch yet). Thus, I just merged your changes to master
(commit f96a293d146d3dc54f8ecfaa1d3dfc669bf4198d).
comment:4 Changed 12 months ago by
Keywords: | tbb-backported added |
---|
Replying to gk:
Thanks, looks good to me. No need for a patch for
maint-1.9.7
as we are using 1.9.8.X for the 7.5 series (there is nomaint-1.9.8
branch yet). Thus, I just merged your changes tomaster
(commit f96a293d146d3dc54f8ecfaa1d3dfc669bf4198d).
That's on maint-1.9.8
now, too.
Note: See
TracTickets for help on using
tickets.
Here is a patch for review:
https://github.com/arthuredelstein/torbutton/commit/25016
The same patch on top of the maint-1.9.7 branch:
https://github.com/arthuredelstein/torbutton/commit/f6fe17fe5dbfe7de2af8ad7021b560bbe11a8a53