Opened 11 months ago

Closed 10 months ago

Last modified 7 months ago

#25020 closed enhancement (fixed)

There should be an easy way to detect the version of an installed bundle.

Reported by: yawning Owned by: tbb-team
Priority: Low Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201802R, tbb-backported
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For numerous reasons, it would be nice if there was a convenient way to detect the version of an installed bundle on disk, that does not involve launching Tor Browser.

Historically there was a versions file deep within the guts of the bundle that could (and was) abused for this purpose, but with the move to rbm, the file no longer exists.

My initial inclination proposal would be that there will be a file Browser/tbb_verson.json with the relevant metadata.

 {"version":"6.5.2","architecture":"linux64","channel":"release","locale":"en-US"}

The build process can trivially auto-generate something like this, and it can be updated by the standard auto update process.

Inspired by #20792, #25012.

Child Tickets

Change History (6)

comment:1 Changed 10 months ago by boklm

Keywords: TorBrowserTeam201802R added
Status: newneeds_review

comment:2 Changed 10 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me, merged to master (commit 1c625c1dcbfbb1ca0b40d965c081b3f5a8f84046).

comment:3 Changed 10 months ago by cypherpunks

The file name is tbb_verson.json instead of tbb_version.json

comment:4 Changed 10 months ago by boklm

Thanks for reporting this. I fixed the file name in commit e7e4cbd526d767d46fe6f728c99492e7e3d6e76c.

comment:5 Changed 9 months ago by boklm

Keywords: tbb-backport added

Micah seems interested to use this tbb_version.json file in torbrowser-launcher:
https://github.com/micahflee/torbrowser-launcher/issues/320

So I think we could backport it to the 7.5 series.

comment:6 in reply to:  5 Changed 7 months ago by gk

Keywords: tbb-backported added; tbb-backport removed

Replying to boklm:

Micah seems interested to use this tbb_version.json file in torbrowser-launcher:
https://github.com/micahflee/torbrowser-launcher/issues/320

So I think we could backport it to the 7.5 series.

Done with commit 38e9d1caaa0d7cf49e4052e7c709b48ebdba9e31 and f99490f12132557981907254495d2b1d6053018e on maint-7.5. Should be available in 7.5.4.

Note: See TracTickets for help on using tickets.