Opened 9 years ago

Closed 8 years ago

Last modified 7 years ago

#2503 closed defect (fixed)

Tor describes HTTPS proxy 403 errors as 'unexpected status code'

Reported by: rransom Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: easy tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When Tor tries to connect to a relay or bridge through an HTTPS proxy, and the CONNECT request is rejected with a 403 error code (meaning 'Forbidden'), Tor describes the 403 response as an 'unexpected status code'. 403 errors should be logged with a more correct/useful message, and there are probably other error codes we should describe better as well.

For 403 errors, we could log "... proxy refused to allow connection to %s".

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by nickm

Keywords: easy added
Milestone: Tor: 0.2.3.x-final

marking this for 0.2.3, but if somebody does a patch for 0.2.2, that'd probably be fine too.

comment:2 Changed 8 years ago by mikey

Milestone: Tor: 0.2.3.x-finalTor: 0.2.2.x-final
Status: newneeds_review

Hello, here's my fix for this 'easy' bug:

https://github.com/mikey99/tor/commits/bug2503

appears ready to be 'pulled', but I'm new to git/github.

Please let me know how to notify you of future fixes.

Thanks!

comment:3 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks fine to me. Merging to 0.2.2 and 0.2.3 and closing this ticket.

One thing for future patches: by convention, we make a new file in the "changes" directory every time we land a feature, bufix, or substantial refactoring. At release time, these all get rolled into the changelog file. I wrote one for this bug as 379de3d10a.

Also, please let me know if there is a name you would like to get credited as other than just "mikey".

Cheers!

comment:4 Changed 7 years ago by nickm

Keywords: tor-client added

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.