Opened 23 months ago

Last modified 20 months ago

#25068 new defect

Make HSIntro consistent with rend_service_descriptor_t.protocols

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.5.3-alpha
Severity: Normal Keywords: tor-hs, doc?, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

HSIntro supports protocol versions 3 and 4:

   The "HSIntro" protocol handles introduction points.

   "3" -- supports authentication as of proposal 121 in Tor
          0.2.1.6-alpha.

   "4" -- support ed25519 authentication keys which is defined by the HS v3
          protocol as part of proposal 224 in Tor 0.3.0.4-alpha.

But rend_service_update_descriptor() says "intro protocols 2 and 3":

  /* Support intro protocols 2 and 3. */
  d->protocols = (1 << 2) + (1 << 3);

I think we need to delete "2" here.

And rend_service_descriptor_t says "introduce/rendezvous" 0-3:

  /** Bitmask: which introduce/rendezvous protocols are supported?
   * (We allow bits '0', '1', '2' and '3' to be set.) */
  unsigned protocols : REND_PROTOCOL_VERSION_BITMASK_WIDTH;

I think we need to delete "/rendezvous" and 0-2 here.

This seems to be a bug in 496fe68 in 0.2.5.3-alpha.

Child Tickets

Change History (4)

comment:1 Changed 23 months ago by dgoulet

I think that this was part of the idea of removing v0 and v1 support as well from the code which we wanted to do when prop224 came out so we do ONE big change for hidden services at once. Else, this creates a version leak.

But that never happened... #15621

Either we keep it in until we actually phase out v2 entirely (years to come) or we just do it and consider that "well yeah the HS tor version can leak but maybe that ain't a big deal?".

comment:2 Changed 21 months ago by nickm

Keywords: 034-triage-20180328 added

comment:3 Changed 21 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:4 Changed 20 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.