Opened 9 months ago

Closed 9 months ago

#25070 closed defect (fixed)

protover_get_supported_protocols() should include Link=5 as of 0.3.1.1-alpha

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version: Tor: 0.3.1.1-alpha
Severity: Normal Keywords: protover, rust, 031-backport, 032-backport
Cc: Actual Points: 0.3
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

Fortunately, link version negotiation does not rely on protover.
But I added some unit tests to make sure we check for new Link versions.

This isn't easy, because most protovers don't expose supported versions in headers. And those that do, don't expose a list or a maximum version. I opened #25069 to refactor the code so it's easier to test.

Child Tickets

Change History (2)

comment:1 Changed 9 months ago by teor

Status: assignedneeds_review

Please see my branches on https://github.com/teor2345/tor.git :

  • bug25070: branch on master with C protover, Rust protover, unit tests, and changes file
  • bug25070_031: branch on maint-0.3.1 with C protover and changes file

(The unit tests won't backport, because they depend on some 0.3.2 and 0.3.3 features. And Rust was introduced in 0.3.3.1-alpha.)

Do I need to increment the crate version in src/rust/protover/Cargo.toml?

comment:2 Changed 9 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

lgtm; Merged those to master and maint-0.3.1 respectively.

Note: See TracTickets for help on using tickets.