Opened 8 months ago

Closed 7 months ago

#25071 closed enhancement (implemented)

Add a test-rust make target to the Makefile

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rust, review-group-32
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: isis Sponsor:

Description

I can't quite work out how to run src/test/test_rust.sh by itself. It would be handy to have a target that runs it.

I tried, but I can't work out how to do that easily.

Child Tickets

Change History (9)

comment:1 Changed 8 months ago by nickm

I think that setting the "abs_top_builddir" variable will be key -- that, or replacing the the "../../.." default with maybe "." ? I'm not sure.

comment:2 in reply to:  1 Changed 8 months ago by teor

Replying to nickm:

I think that setting the "abs_top_builddir" variable will be key -- that, or replacing the the "../../.." default with maybe "." ? I'm not sure.

No setting for abs_top_builddir worked for me, I think test_rust.sh might be missing a path reference somewhere.
Typically, we would use dirname "$0"/../../.. but there's still the path reference issue.

comment:3 Changed 8 months ago by nickm

I think using dirname "$0" here would get the sourcedir, not the builddir.

comment:4 Changed 8 months ago by nickm

Owner: set to nickm
Status: newaccepted

I've made a simple patch here: tests_rust.

comment:5 Changed 8 months ago by nickm

Status: acceptedneeds_review

comment:6 Changed 7 months ago by nickm

Keywords: review-group-32 added

comment:7 Changed 7 months ago by isis

Reviewer: isis

Assigning tickets from review-group-32 to myself for review this week.

comment:8 Changed 7 months ago by isis

Status: needs_reviewmerge_ready

LGTM. I tried using in both an in-tree build and an out-of-tree build.

comment:9 Changed 7 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

whoa, I can't believe anything I worked on actually worked correctly out-of-tree without extensive revision.

thanks for the review! merged to master.

Note: See TracTickets for help on using tickets.